feat: update versions colors #2530
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemmufazalov
commented
Jul 2, 2025
| @@ -32,7 +32,7 @@ export function VersionsContainer({cluster, loading}: VersionsContainerProps) { | |||
| {tablets: false, fieldsRequired: ['SystemState', 'SubDomainKey']}, | |||
| {pollingInterval: autoRefreshInterval}, | |||
| ); | |||
| const versionToColor = useVersionToColorMap(); | |||
| const versionToColor = useVersionToColorMap(cluster); | |||
There was a problem hiding this comment.
cluster param was forgot here, that's why the bar in Versions was always grey
artemmufazalov
force-pushed
the
2497-new-versions-colors
branch
from
7222df0 to
7e5707a
Compare
artemmufazalov
commented
Jul 2, 2025
| --versions-pink-4: #ffb0e1; | ||
| } | ||
| &_theme_dark, | ||
| &_theme_dark-hc { |
artemmufazalov
commented
Jul 2, 2025
| @@ -0,0 +1,106 @@ | |||
| .g-root { | |||
| &_theme_light, | |||
| &_theme_light-hc { | |||
artemmufazalov
commented
Jul 2, 2025
| @@ -2,6 +2,7 @@ | |||
| @forward './themes.scss'; | |||
| @forward './unipika.scss'; | |||
| @forward './illustrations.scss'; | |||
| @forward './versions.scss'; | |||
There was a problem hiding this comment.
It's important to not forget to import it in internal and EM version
astandrik
approved these changes
Jul 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2497
Stand: https://nda.ya.ru/t/FfJLiROc7FzRMm
Palette: https://nda.ya.ru/t/X93Hbu647FzhFS
CI Results
Test Status:⚠️ FLAKY
📊 Full Report
Test Changes Summary ⏭️1
⏭️ Skipped Tests (1)
Bundle Size: 🔺
Current: 84.01 MB | Main: 84.00 MB
Diff: +9.54 KB (0.01%)
ℹ️ CI Information